Review Request 126403: Get rid of QApplication dependency
Thomas Lübking
thomas.luebking at gmail.com
Fri Jan 1 20:55:25 UTC 2016
> On Jan. 1, 2016, 7:47 p.m., David Faure wrote:
> > src/platforms/xcb/kwindowsystem.cpp, line 891
> > <https://git.reviewboard.kde.org/r/126403/diff/1/?file=424255#file424255line891>
> >
> > isn't that "return displayGeometry()?"
> >
> > If not, then at least something like QRect(QPoint(0,0), displayGeometry().size()) (encapsulated in a convenience function) would avoid calling displayGeometry() twice.
Yes, is. Patch evolution had displayWidth/Height from the root window before I figured we'd better clone the combined screen area approach. Thanks for the catch.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126403/#review90395
-----------------------------------------------------------
On Dec. 17, 2015, 3:38 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126403/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2015, 3:38 p.m.)
>
>
> Review request for KDE Frameworks, kwin and Albert Astals Cid.
>
>
> Bugs: 354811
> https://bugs.kde.org/show_bug.cgi?id=354811
>
>
> Repository: kwindowsystem
>
>
> Description
> -------
>
> summarized, alternative to https://git.reviewboard.kde.org/r/126397/
>
> NOTICE: this compiles but is otherwise *completely* untested!
>
>
> Diffs
> -----
>
> src/platforms/xcb/kwindowsystem.cpp 9d28704
>
> Diff: https://git.reviewboard.kde.org/r/126403/diff/
>
>
> Testing
> -------
>
> no, not the least. esp. not on the bug.
>
>
> Thanks,
>
> Thomas Lübking
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160101/e990c981/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list