Review Request 125869: Convert all io slave .protocol data to json and embed it.
Alex Richardson
arichardson.kde at gmail.com
Fri Jan 1 18:12:48 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review90411
-----------------------------------------------------------
I added support for translating the ExtraNames key here: https://svn.reviewboard.kde.org/r/7154/
- Alex Richardson
On Dec. 28, 2015, 7:25 p.m., Christoph Cullmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2015, 7:25 p.m.)
>
>
> Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David Faure, and Luigi Toscano.
>
>
> Repository: kio
>
>
> Description
> -------
>
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
>
>
> Diffs
> -----
>
> src/core/kprotocolinfo.cpp 7bfb9ad
> src/protocoltojson/main.cpp 05b9364
>
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
>
>
> Testing
> -------
>
> Tests still work (one needed patching, as the exec line contains now the full path).
>
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, sometimes it works, sometimes not :/ but even without this change.
>
>
> File Attachments
> ----------------
>
> trash.json
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/28/6ab2cd95-b0bd-4347-80f2-6f753fa50425__trash.json
>
>
> Thanks,
>
> Christoph Cullmann
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160101/a0426c95/attachment.html>
More information about the Kde-frameworks-devel
mailing list