Review Request 126474: Port QRegExp to QRegularExpression in kshorturifilter

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126474/#review90403
-----------------------------------------------------------

Ship it!



src/urifilters/shorturi/kshorturifilter.cpp (line 58)
<https://git.reviewboard.kde.org/r/126474/#comment61838>

    "despite" sounds like the api docs say that it's not thread safe. AFAICS the docs don't say anything either way. I agree that one shouldn't assume thread-safety unless explicitly documented, but I think it's just an omission in the doc, the whole point of the QRegularExpression API is thread safety.


- David Faure


On Dec. 28, 2015, 2:20 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126474/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2015, 2:20 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> A static QRegExp was used but it is not thread safe. QRegularExpression
> seems to be.
> 
> BUG: 352356
> 
> 
> Diffs
> -----
> 
>   src/urifilters/shorturi/kshorturifilter.cpp 6002ec6925c0acdd20a053f98baca46863f69fa6 
> 
> Diff: https://git.reviewboard.kde.org/r/126474/diff/
> 
> 
> Testing
> -------
> 
> I ran the autotests which includes urifilter and I've run krunner which uses it extensively.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160101/0d205dcd/attachment.html>