Review Request 127210: Fix warnings

Martin Klapetek martin.klapetek at gmail.com
Mon Feb 29 18:27:48 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127210/#review92925
-----------------------------------------------------------


Ship it!




Ship It!

- Martin Klapetek


On Feb. 28, 2016, 9:13 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127210/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2016, 9:13 p.m.)
> 
> 
> Review request for KDE Frameworks and KDEPIM.
> 
> 
> Repository: kpeople
> 
> 
> Description
> -------
> 
> * Fixes Coverity issue that notifies that the factory might be null by checking and adding a warning in case it is.
> * Uses the correct overload for ::create, this way we don't get a _using deprecated API_ warning anymore.
> 
> 
> Diffs
> -----
> 
>   src/widgets/actions.cpp 5ac56a2 
> 
> Diff: https://git.reviewboard.kde.org/r/127210/diff/
> 
> 
> Testing
> -------
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160229/a13e34fa/attachment.html>


More information about the Kde-frameworks-devel mailing list