Review Request 127136: XmlGui: Use non native Language name as fallback in KSwitchlangaugeDialog

[Andre Heinecke]

> On Feb. 27, 2016, 1:51 p.m., David Faure wrote:
> > src/kswitchlanguagedialog_p.cpp, line 343
> > <https://git.reviewboard.kde.org/r/127136/diff/2/?file=445160#file445160line343>
> >
> >     atleast windows -> at least Windows
> >     (missing space)

As Thiago pointed out in the Bug report, my initial analysis that this is a Windows issue was wrong. According to the QtBug this is a general Qt problem so I've removed the "some platforms / at least Windows" part of the comment.


- Andre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127136/#review92833
-----------------------------------------------------------


On Feb. 23, 2016, 3:16 p.m., Andre Heinecke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127136/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2016, 3:16 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> -------
> 
> While packaging Kleopatra's translations for Gpg4win I've noticed that there were blank entries in the Switchlanguagedialog.
> Apperantly QLocale::nativeLanguageName can return an Empty string (Qt 5.5 on Windows).
> 
> This patch handles this and uses the non native QLocale::languageToString as a fallback. The idea is that a non native Name is better then no name (and a blank entry in the dialog) at all.
> 
> Ideally every language would have a native name but until this is the case I think this fallback makes sense.
> 
> 
> Diffs
> -----
> 
>   src/kswitchlanguagedialog_p.cpp 039daea 
> 
> Diff: https://git.reviewboard.kde.org/r/127136/diff/
> 
> 
> Testing
> -------
> 
> See attached screenshots of Kleopatra's switchlanguage dialog before and after the patch. Low German is an example where the native name was empty.
> 
> 
> File Attachments
> ----------------
> 
> Dialog before the patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/02/22/a6a31417-1ad6-432e-bee9-65a367fac28d__languages_before.png
> Dialog after the patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/02/22/762062c5-ff18-47da-aeb0-93b16ca28883__languages_after.png
> 
> 
> Thanks,
> 
> Andre Heinecke
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160229/ce404c71/attachment.html>