Review Request 127209: Fix some issues found by Coverity

[Aleix Pol Gonzalez]

> On Feb. 29, 2016, 4:30 p.m., Kai Uwe Broulik wrote:
> > src/lib/io/kprocess_p.h, line 33
> > <https://git.reviewboard.kde.org/r/127209/diff/3/?file=446022#file446022line33>
> >
> >     Why not have a constructor that takes the q ptr?
> >     
> >     The only code that uses it does:
> >     
> >     d_ptr(new KProcessPrivate)
> >     d_ptr->q_ptr = this;

Yes... I've been pondering doing this everywhere. In fact we have many of those. If there's consensus that we want this, I can do the changes.

Also probably having q_ptr to nullptr for a brief instance doesn't help a lot either.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127209/#review92912
-----------------------------------------------------------


On Feb. 29, 2016, 2:29 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127209/
> -----------------------------------------------------------
> 
> (Updated Feb. 29, 2016, 2:29 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Mostly initializing values and using printf() correctly.
> 
> 
> Diffs
> -----
> 
>   src/lib/io/kdirwatch.cpp f2fd3b8 
>   src/lib/io/kprocess_p.h 70fe91f 
>   src/lib/kaboutdata.cpp a220977 
>   src/lib/randomness/krandom.cpp bdbdec6 
>   src/lib/util/kformatprivate.cpp 3d98007 
> 
> Diff: https://git.reviewboard.kde.org/r/127209/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160229/c292421f/attachment-0001.html>