Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

Thomas Lübking thomas.luebking at gmail.com
Mon Feb 29 09:29:45 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127216/#review92888
-----------------------------------------------------------



just store the widget/window position when hiding the window (ie. in the else branch) and avoid walkign across the window system to figure the restore position.

The patch will fail miserably if there's no WM, the SNI window becomes unmanaged (again) and half a dozen other occasions.

- Thomas Lübking


On Feb. 29, 2016, 5:18 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127216/
> -----------------------------------------------------------
> 
> (Updated Feb. 29, 2016, 5:18 a.m.)
> 
> 
> Review request for KDE Frameworks, Martin Gräßlin, Thomas Lübking, and Martin Klapetek.
> 
> 
> Bugs: 356523
>     https://bugs.kde.org/show_bug.cgi?id=356523
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> I add specific X11 code till we have proper move in KWindowSystem
> 
> 
> Diffs
> -----
> 
>   src/kstatusnotifieritem.cpp cf3e7b5 
> 
> Diff: https://git.reviewboard.kde.org/r/127216/diff/
> 
> 
> Testing
> -------
> 
> Tested on pixel ration = 1
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160229/88c82021/attachment.html>


More information about the Kde-frameworks-devel mailing list