Review Request 127201: Fix svg icon path resolving in IconItem

Xuetian Weng wengxt at gmail.com
Sat Feb 27 18:52:48 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127201/
-----------------------------------------------------------

Review request for KDE Frameworks, Plasma and Marco Martin.


Repository: plasma-framework


Description
-------

Well.. the bug should be obvious:
1. QString iconPath overrides the iconPath in a higher scope. introduced in https://git.reviewboard.kde.org/r/126168/
2. iconPath not assigned, also introduced in https://git.reviewboard.kde.org/r/126168/
3. svgz -> svg?? introduced in https://git.reviewboard.kde.org/r/126557/


Diffs
-----

  src/declarativeimports/core/iconitem.cpp 085f284 

Diff: https://git.reviewboard.kde.org/r/127201/diff/


Testing
-------

tested with qmlscene with Plasma.IconItem.


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160227/3c7be06c/attachment.html>


More information about the Kde-frameworks-devel mailing list