Review Request 127090: Clean KWalletQuery cmake file

Aleix Pol Gonzalez aleixpol at kde.org
Thu Feb 25 23:04:59 UTC 2016



> On Feb. 25, 2016, 7:39 p.m., Hrvoje Senjan wrote:
> > This is not 100% correct. KF5DocTools is searched nowhere, so doc subdir is now never added.

Good catch! Fixed: http://commits.kde.org/kwallet-framework/3ea2c94aa2ab7e01962ad4fb64e1232f9f8e7a55


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127090/#review92774
-----------------------------------------------------------


On Feb. 25, 2016, 1:34 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127090/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2016, 1:34 a.m.)
> 
> 
> Review request for KDE Frameworks and Valentin Rusu.
> 
> 
> Repository: kwallet
> 
> 
> Description
> -------
> 
> I saw it didn't build because I needed a build with KDocTools, ended up cleaning a bit more.
> 
> 
> Diffs
> -----
> 
>   src/runtime/kwallet-query/CMakeLists.txt 42b4687 
>   src/runtime/kwallet-query/src/main.cpp c19cb29 
> 
> Diff: https://git.reviewboard.kde.org/r/127090/diff/
> 
> 
> Testing
> -------
> 
> Built with and without KDocTools.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160225/b9367eff/attachment.html>


More information about the Kde-frameworks-devel mailing list