Review Request 127033: Add <app dir>/../share/hunspell/ to dictionary search path

[Kåre Särs]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127033/
-----------------------------------------------------------

(Updated Feb. 24, 2016, 8:25 p.m.)


Review request for KDE Frameworks, Laurent Montel and Martin Tobias Holmedahl Sandsmark.


Changes
-------

Use QFile::encodeName() and add '/' in composeDictName()


Repository: sonnet


Description
-------

The default search path for hunspell dictionaries is /usr/share/hunspell/, but that is not a very common directory on windows ;)

For Windows and Mac there are some extra search paths defined in side #ifdefs, but they are hardcoded to the LibreOffice dictionary directories. Unfortunately the extra Windows path points to a 32bit LibreOffice 5 on a 64 bit Windows directory. This patch adds <app dir>/../share/hunspell/ to the search path in case the default is not found. 

If wanted I can add a CMake define for specifying the path relative to the application directory.


Diffs (updated)
-----

  src/core/guesslanguage.cpp e8deb90 
  src/plugins/hunspell/CMakeLists.txt 144515b 
  src/plugins/hunspell/hunspellclient.cpp 3da7219 
  src/plugins/hunspell/hunspelldict.h b825d7d 
  src/plugins/hunspell/hunspelldict.cpp bc5c314 

Diff: https://git.reviewboard.kde.org/r/127033/diff/


Testing
-------

Compiled Sonnet and Kate on Windows and got spelling to work :)

It is now possible to add dictionaries to a relocatable <App dir>/../share/hunspell/ and get spelling to work without depending on LibreOffice installation on Windows.


Thanks,

Kåre Särs

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160224/4a8d21ec/attachment.html>