Review Request 127145: KLinkItemSelectionModel: Don't store model locally

[Stephen Kelly]

> On Feb. 24, 2016, 12:36 a.m., Aleix Pol Gonzalez wrote:
> > Ship It!
> 
> Aleix Pol Gonzalez wrote:
>     Eh.. wait, we still support Qt 5.3, will that be a problem?

Hi Aleix,

Good catch! It's not a problem in this commit, but following commits would not compile with Qt 5.3 because of a connect() to a method that doesn't exist yet, and because of unit tests calling setModel on the QItemSelectionModel.

I wrapped those things in ifdefs and tested successfully with Qt 5.3. I pushed the result to my branch again on github.

Thanks,


- Stephen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127145/#review92693
-----------------------------------------------------------


On Feb. 22, 2016, 4:30 p.m., Stephen  Kelly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127145/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2016, 4:30 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> -------
> 
> The model can be changed after the constructor is run as of Qt 5.5.
> 
> At this point, the KLinkItemSelectionModel would still break if that is
> attempted, so a unit test comes later.
> 
> 
> Diffs
> -----
> 
>   src/klinkitemselectionmodel.cpp 1b676e87128d83586b62f94f9652b25111e766a5 
> 
> Diff: https://git.reviewboard.kde.org/r/127145/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Stephen  Kelly
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160224/f7349b04/attachment-0001.html>