Review Request 127145: KLinkItemSelectionModel: Don't store model locally
Aleix Pol Gonzalez
aleixpol at kde.org
Wed Feb 24 00:36:22 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127145/#review92693
-----------------------------------------------------------
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Feb. 22, 2016, 5:30 p.m., Stephen Kelly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127145/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 5:30 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kitemmodels
>
>
> Description
> -------
>
> The model can be changed after the constructor is run as of Qt 5.5.
>
> At this point, the KLinkItemSelectionModel would still break if that is
> attempted, so a unit test comes later.
>
>
> Diffs
> -----
>
> src/klinkitemselectionmodel.cpp 1b676e87128d83586b62f94f9652b25111e766a5
>
> Diff: https://git.reviewboard.kde.org/r/127145/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Stephen Kelly
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160224/198a09d3/attachment.html>
More information about the Kde-frameworks-devel
mailing list