Review Request 127140: KModelIndexProxyMapper: Add some asserts

Aleix Pol Gonzalez aleixpol at kde.org
Wed Feb 24 00:35:19 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127140/#review92691
-----------------------------------------------------------




src/kmodelindexproxymapper.cpp (line 232)
<https://git.reviewboard.kde.org/r/127140/#comment63178>

    Get the condition inside the assert?
    
    `Q_ASSERT(seekSelection.isEmpty() || seekSelection.first().model() == proxy);`


Same for the rest.

- Aleix Pol Gonzalez


On Feb. 22, 2016, 4:35 p.m., Stephen  Kelly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127140/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2016, 4:35 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> -------
> 
> KModelIndexProxyMapper: Add some asserts
> 
> 
> Diffs
> -----
> 
>   src/kmodelindexproxymapper.cpp ae9e69a558f90bf498da730f96af773e3eb91901 
> 
> Diff: https://git.reviewboard.kde.org/r/127140/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Stephen  Kelly
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160224/a897c4a1/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list