Review Request 127046: Move popup menu image actions into a submenu

[Jonathan Marten]

> On Feb. 12, 2016, 2:37 p.m., Thomas Pfeiffer wrote:
> > I wouldn't say that all actions for images are rarely used.
> > I don't see why viewing, copying or saving an image is less frequently done than the same things regarding the link. Can't we have those three still on the first level and then a "More..." option with further actions?
> 
> Jonathan Marten wrote:
>     I wouldn't have said "rarely used":  certainly in my experience I use all of these options occasionally, but nowhere near as often as "Open in new tab", "Save link as", "Open with" etc.
>     
>     Obviously any of the image options could appear at the top level instead of in a submenu, but however they are arranged there will be dispute over what should be where.  The only sensible options I can think of to satisfy everyone would be "everything at top level" (as of now), or "everything in a submenu" (which groups them all together, provides a place to show the name of the image, and minimises the size of the menu).
> 
> Luigi Toscano wrote:
>     What other browsers do?

Mozilla: has "View Image", "Copy Image", "Copy Image Location", (separator), "Save Image As", "Share this image", "Email Image", "Set as desktop background", "View Image Info".  Far too normal many IMHO, the menu height doubles over an image.

Chromium: has "Open image in new tab", "Save image as", "Copy image", "Copy image address", "Search Google for image".


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127046/#review92299
-----------------------------------------------------------


On Feb. 11, 2016, 6:18 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127046/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2016, 6:18 p.m.)
> 
> 
> Review request for KDE Frameworks and KDE Usability.
> 
> 
> Repository: khtml
> 
> 
> Description
> -------
> 
> The popup menu over an image (with actions "Save Image As..." etcetera, see screen shot) has in total 6 image actions which are not frequently used but make the menu very long.  Moving these actions onto a submenu makes the top level menu smaller and more logically grouped.
> 
> 
> Diffs
> -----
> 
>   src/khtml_ext.cpp 0f522f4 
> 
> Diff: https://git.reviewboard.kde.org/r/127046/diff/
> 
> 
> Testing
> -------
> 
> Built KHTML with these changes, tested in Konqueror.
> 
> 
> File Attachments
> ----------------
> 
> Popup menu before
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/02/11/55c12311-73a3-472a-8a9a-6b6b9fce9de7__before.png
> Popup menu after
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/02/11/313dbe3b-efb4-475c-bf76-8516f5bc85b4__after.png
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160222/cf8ed3cf/attachment-0001.html>