Review Request 127142: Add a property indicating whether the models form a connected chain.

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127142/#review92641
-----------------------------------------------------------




src/kmodelindexproxymapper.cpp (lines 105 - 106)
<https://git.reviewboard.kde.org/r/127142/#comment63150>

    Braces pls
    
    Also, be careful when using range-for on non const Qt containers: http://www.dvratil.cz/2015/06/qt-containers-and-c11-range-based-loops/
    
    I'm not sure whether we're allowed to use it in Frameworks, though.



src/kmodelindexproxymapper.cpp (lines 160 - 161)
<https://git.reviewboard.kde.org/r/127142/#comment63151>

    Same line


- Kai Uwe Broulik


On Feb. 22, 2016, 3:34 nachm., Stephen  Kelly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127142/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2016, 3:34 nachm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> -------
> 
> Replace existing asserts with a query and notification API.  This makes
> the class more suitable for use in QML.
> 
> 
> Diffs
> -----
> 
>   autotests/kmodelindexproxymappertest.cpp PRE-CREATION 
>   src/kmodelindexproxymapper.h 9c4a63d7953ce3572cee47c5acc27f422c383f3b 
>   src/kmodelindexproxymapper.cpp ae9e69a558f90bf498da730f96af773e3eb91901 
> 
> Diff: https://git.reviewboard.kde.org/r/127142/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Stephen  Kelly
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160222/f3a6e94d/attachment.html>