Review Request 127147: KLinkItemSelectionModel: Make the linked selection model settable

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127147/#review92640
-----------------------------------------------------------



Bunch of coding style nitpicks.


src/klinkitemselectionmodel.h (lines 109 - 110)
<https://git.reviewboard.kde.org/r/127147/#comment63145>

    Coding style: QItemSelectionModel *, space between name and asterisk



src/klinkitemselectionmodel.cpp (line 40)
<https://git.reviewboard.kde.org/r/127147/#comment63146>

    Perhaps new connext syntax with lambda?



src/klinkitemselectionmodel.cpp (line 64)
<https://git.reviewboard.kde.org/r/127147/#comment63147>

    Q_NULLPTR



src/klinkitemselectionmodel.cpp (line 82)
<https://git.reviewboard.kde.org/r/127147/#comment63148>

    Coding style: no space after asterisk



src/klinkitemselectionmodel.cpp (lines 116 - 117)
<https://git.reviewboard.kde.org/r/127147/#comment63149>

    Coding Style: Put on same line


- Kai Uwe Broulik


On Feb. 22, 2016, 3:34 nachm., Stephen  Kelly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127147/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2016, 3:34 nachm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> -------
> 
> KLinkItemSelectionModel: Make the linked selection model settable
> 
> 
> Diffs
> -----
> 
>   autotests/klinkitemselectionmodeltest.h 6e9c178cd99ed5479e2cee34492a8acd7e5a3f75 
>   autotests/klinkitemselectionmodeltest.cpp 74d72e4858dfd8bab48a71d260af86d838484d26 
>   src/klinkitemselectionmodel.h c871121fa9a791b6030f5ff3a104d8d3bdcbe79d 
>   src/klinkitemselectionmodel.cpp 1b676e87128d83586b62f94f9652b25111e766a5 
> 
> Diff: https://git.reviewboard.kde.org/r/127147/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Stephen  Kelly
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160222/f21ec791/attachment-0001.html>