Review Request 127148: KLinkItemSelectionModel: Add new default constructor.

Kai Uwe Broulik kde at privat.broulik.de
Mon Feb 22 15:47:03 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127148/#review92639
-----------------------------------------------------------




src/klinkitemselectionmodel.h (line 108)
<https://git.reviewboard.kde.org/r/127148/#comment63143>

    explicit? Also, Q_NULLPTR



src/klinkitemselectionmodel.cpp (line 95)
<https://git.reviewboard.kde.org/r/127148/#comment63144>

    We cannot use nullptr in Frameworks, use Q_NULLPTR


- Kai Uwe Broulik


On Feb. 22, 2016, 3:34 nachm., Stephen  Kelly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127148/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2016, 3:34 nachm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> -------
> 
> Make it possible to construct this in QML
> 
> 
> Diffs
> -----
> 
>   src/klinkitemselectionmodel.h c871121fa9a791b6030f5ff3a104d8d3bdcbe79d 
>   src/klinkitemselectionmodel.cpp 1b676e87128d83586b62f94f9652b25111e766a5 
> 
> Diff: https://git.reviewboard.kde.org/r/127148/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Stephen  Kelly
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160222/e719afd8/attachment.html>


More information about the Kde-frameworks-devel mailing list