Review Request 127145: KLinkItemSelectionModel: Don't store model locally

Stephen Kelly ske at ableton.com
Mon Feb 22 15:34:44 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127145/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: kitemmodels


Description
-------

The model can be changed after the constructor is run as of Qt 5.5.

At this point, the KLinkItemSelectionModel would still break if that is
attempted, so a unit test comes later.


Diffs
-----

  src/klinkitemselectionmodel.cpp 1b676e87128d83586b62f94f9652b25111e766a5 

Diff: https://git.reviewboard.kde.org/r/127145/diff/


Testing
-------


Thanks,

Stephen  Kelly

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160222/ddedb816/attachment.html>


More information about the Kde-frameworks-devel mailing list