Review Request 126774: Fix many warnings presented by clazy

Nick Shaforostoff shafff at ukr.net
Sun Feb 21 04:52:54 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126774/#review92601
-----------------------------------------------------------




src/core/kprotocolinfofactory.cpp (line 114)
<https://git.reviewboard.kde.org/r/126774/#comment63125>

    please use QLatin1String here: there is a special overload for it



src/core/kprotocolmanager.cpp (line 569)
<https://git.reviewboard.kde.org/r/126774/#comment63126>

    please revert back to QLatin1String here, s there is special overload for it



src/core/kprotocolmanager.cpp (line 838)
<https://git.reviewboard.kde.org/r/126774/#comment63127>

    please revert back to QLatin1String, as there is a special overload for it. if you really want to reduce number of [re]allocs then change it to one big assignment:
    
    d->useragent = ... + ... + ... + ...;
    
    and make sure QT_USE_STRINGBUILDER is defined



src/core/kprotocolmanager.cpp (line 940)
<https://git.reviewboard.kde.org/r/126774/#comment63128>

    please revert back to QLatin1String, as there is a special overload for it. if you really want to reduce number of [re]allocs then change it to one big assignment:
    
    info += ... + ... + ... + ...;
    
    and make sure QT_USE_STRINGBUILDER is defined


- Nick Shaforostoff


On Feb. 20, 2016, 8:41 p.m., Russell Greene wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126774/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2016, 8:41 p.m.)
> 
> 
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Fix many warnings presented by clazy
> 
> I ran the clazy static anaylizer on the codebase and fixed many of the errors.
> 
> Many of these were using QStringLiteral instead of QString, which removes an allocation, including Q_OBJECT macros, adding const ref instad of const lvalue, stuff like that.
> 
> 
> Diffs
> -----
> 
>   autotests/http/httpheaderdispositiontest.cpp ac41656 
>   autotests/http/httpheadertokenizetest.cpp e57be09 
>   autotests/jobtest.cpp dfbfba9 
>   autotests/kacltest.cpp 2b88906 
>   autotests/kcookiejar/kcookiejartest.cpp dab6987 
>   autotests/kfileitemtest.cpp 49d11e1 
>   autotests/kfileplacesmodeltest.cpp effc95b 
>   autotests/klocalsocketservertest.cpp 9b7f246 
>   autotests/klocalsockettest.cpp 0d831f2 
>   autotests/kmountpointtest.cpp f6eccd8 
>   autotests/knewfilemenutest.cpp 1b11f15 
>   autotests/kprotocolinfotest.cpp 812f7f7 
>   autotests/ktcpsockettest.cpp 640d871 
>   autotests/kurlnavigatortest.cpp 1b295c3 
>   autotests/udsentry_benchmark.cpp 16c8b7e 
>   src/core/dataprotocol_p.h 784226b 
>   src/core/global.cpp eaa4264 
>   src/core/job_error.cpp 7943cb3 
>   src/core/kprotocolinfofactory.cpp 1329b6b 
>   src/core/kprotocolmanager.cpp bd42c9e 
>   src/core/ksambasharedata.cpp b63f518 
>   src/core/ksslcertificatemanager.cpp 07feda4 
>   src/core/restorejob.cpp ee5cca9 
>   src/core/sessiondata.cpp d21ab21 
>   src/core/simplejob.cpp 440fa62 
>   src/core/slave.cpp 5ae4d97 
>   src/core/slavebase.cpp a9bf648 
>   src/core/statjob.cpp e55e3b4 
>   src/core/storedtransferjob.cpp 3e86cb9 
>   src/core/tcpslavebase.cpp 2bd1c0f 
>   src/filewidgets/defaults-kfile.h 825a297 
>   src/filewidgets/defaultviewadapter_p.h 79381e4 
>   src/filewidgets/kdiroperator.cpp 9c2b6be 
>   src/filewidgets/kfilecopytomenu.cpp dab5db6 
>   src/filewidgets/kfileplacesitem.cpp 1748188 
>   src/filewidgets/kfileplacesmodel.cpp e9d37a9 
>   src/filewidgets/kfileplacesview.cpp 4121191 
>   src/filewidgets/knewfilemenu.cpp b249898 
>   src/filewidgets/kurlnavigator.cpp 64d2a6d 
>   src/ioslaves/ftp/ftp.cpp 7477a6a 
>   src/ioslaves/http/http.cpp 76da711 
>   src/ioslaves/http/kcookiejar/kcookiejar.cpp c06882a 
>   src/ioslaves/http/kcookiejar/kcookieserver.cpp 3e7dd8c 
>   src/ioslaves/trash/kcmtrash.cpp 79c2ca7 
>   src/ioslaves/trash/ktrash.cpp 298a201 
>   src/ioslaves/trash/tests/testtrash.cpp 339aa19 
>   src/ioslaves/trash/trashimpl.cpp 26d9ea8 
>   src/kcms/kio/kcookiespolicyselectiondlg.cpp fcd0763 
>   src/kcms/kio/kproxydlg.cpp fe2583e 
>   src/kcms/kio/main.cpp 387cf89 
>   src/kcms/kio/useragentdlg.cpp a6560b5 
>   src/kcms/kio/useragentinfo.cpp 1459fcc 
>   src/kcms/kio/useragentselectordlg.cpp 3952761 
>   src/kioexec/main.cpp 6f4540f 
>   src/kntlm/kntlm.cpp ed6f388 
>   src/kpac/script.cpp 9b126ca 
>   src/kpasswdserver/kpasswdserver.cpp 7a53300 
>   src/kssld/kssld.cpp fcc3bed 
>   src/protocoltojson/main.cpp 05b9364 
>   src/urifilters/ikws/kuriikwsfiltereng.h c8fbcd2 
>   src/urifilters/ikws/searchprovider.cpp 8652997 
>   src/urifilters/ikws/searchproviderdlg.cpp 4effe08 
>   src/urifilters/localdomain/localdomainurifilter.cpp 4ebd1c0 
>   src/urifilters/shorturi/kshorturifilter.cpp c9024b0 
>   src/widgets/accessmanager.cpp 68f4a27 
>   src/widgets/accessmanagerreply_p.cpp 2ade6fd 
>   src/widgets/delegateanimationhandler.cpp 8e08a0c 
>   src/widgets/fileundomanager.cpp c9790ab 
>   src/widgets/kbuildsycocaprogressdialog.cpp 9ee0644 
>   src/widgets/kfileitemactions.cpp 4343da7 
>   src/widgets/kopenwithdialog.cpp 808af73 
>   src/widgets/kpropertiesdialog.cpp a4fdeb9 
>   src/widgets/krun.cpp af48473 
>   src/widgets/kurlcompletion.cpp 7160491 
>   src/widgets/kurlrequester.cpp 06e9ddb 
> 
> Diff: https://git.reviewboard.kde.org/r/126774/diff/
> 
> 
> Testing
> -------
> 
> I ran the entire test suite with the exact same results as master:
> 
> 
> Running tests...
> Test project /home/russellg/KDE/kio/build
>       Start  1: testtrash
>  1/47 Test  #1: testtrash ........................................   Passed    1.24 sec
>       Start  2: kpasswdservertest
>  2/47 Test  #2: kpasswdservertest ................................   Passed    0.73 sec
>       Start  3: kiocore-kacltest
>  3/47 Test  #3: kiocore-kacltest .................................***Failed    0.04 sec
>       Start  4: kiocore-listdirtest
>  4/47 Test  #4: kiocore-listdirtest ..............................   Passed    0.18 sec
>       Start  5: kiocore-kmountpointtest
>  5/47 Test  #5: kiocore-kmountpointtest ..........................   Passed    0.04 sec
>       Start  6: kiocore-upurltest
>  6/47 Test  #6: kiocore-upurltest ................................   Passed    0.04 sec
>       Start  7: kiocore-dataprotocoltest
>  7/47 Test  #7: kiocore-dataprotocoltest .........................   Passed    0.04 sec
>       Start  8: kiocore-jobtest
>  8/47 Test  #8: kiocore-jobtest ..................................***Exception: Other  0.45 sec
>       Start  9: kiocore-jobremotetest
>  9/47 Test  #9: kiocore-jobremotetest ............................   Passed    0.11 sec
>       Start 10: kiocore-kfileitemtest
> 10/47 Test #10: kiocore-kfileitemtest ............................   Passed    0.08 sec
>       Start 11: kiocore-kprotocolinfotest
> 11/47 Test #11: kiocore-kprotocolinfotest ........................   Passed    0.10 sec
>       Start 12: kiocore-ktcpsockettest
> 12/47 Test #12: kiocore-ktcpsockettest ...........................   Passed    5.28 sec
>       Start 13: kiocore-globaltest
> 13/47 Test #13: kiocore-globaltest ...............................   Passed    0.04 sec
>       Start 14: kiocore-mkpathjobtest
> 14/47 Test #14: kiocore-mkpathjobtest ............................   Passed    0.11 sec
>       Start 15: kiocore-threadtest
> 15/47 Test #15: kiocore-threadtest ...............................   Passed    0.33 sec
>       Start 16: kiocore-udsentrytest
> 16/47 Test #16: kiocore-udsentrytest .............................   Passed    0.04 sec
>       Start 17: kiocore-udsentry_benchmark
> 17/47 Test #17: kiocore-udsentry_benchmark .......................   Passed    3.42 sec
>       Start 18: kiocore-deletejobtest
> 18/47 Test #18: kiocore-deletejobtest ............................   Passed    0.15 sec
>       Start 19: kiocore-klocalsockettest
> 19/47 Test #19: kiocore-klocalsockettest .........................   Passed    0.35 sec
>       Start 20: kiocore-klocalsocketservertest
> 20/47 Test #20: kiocore-klocalsocketservertest ...................   Passed    0.65 sec
>       Start 21: kiowidgets-clipboardupdatertest
> 21/47 Test #21: kiowidgets-clipboardupdatertest ..................   Passed    0.43 sec
>       Start 22: kiowidgets-dropjobtest
> 22/47 Test #22: kiowidgets-dropjobtest ...........................   Passed    4.01 sec
>       Start 23: kiowidgets-krununittest
> 23/47 Test #23: kiowidgets-krununittest ..........................   Passed    0.69 sec
>       Start 24: kiowidgets-kdirlistertest
> 24/47 Test #24: kiowidgets-kdirlistertest ........................   Passed   18.53 sec
>       Start 25: kiowidgets-kdirmodeltest
> 25/47 Test #25: kiowidgets-kdirmodeltest .........................   Passed   12.74 sec
>       Start 26: kiowidgets-kfileitemactionstest
> 26/47 Test #26: kiowidgets-kfileitemactionstest ..................   Passed    0.33 sec
>       Start 27: kiowidgets-fileundomanagertest
> 27/47 Test #27: kiowidgets-fileundomanagertest ...................   Passed    2.43 sec
>       Start 28: kiowidgets-kurifiltertest
> 28/47 Test #28: kiowidgets-kurifiltertest ........................   Passed    6.34 sec
>       Start 29: kiowidgets-kurlcompletiontest
> 29/47 Test #29: kiowidgets-kurlcompletiontest ....................   Passed    0.32 sec
>       Start 30: kiowidgets-kurlrequestertest
> 30/47 Test #30: kiowidgets-kurlrequestertest .....................   Passed    0.35 sec
>       Start 31: kiowidgets-jobguitest
> 31/47 Test #31: kiowidgets-jobguitest ............................   Passed    0.66 sec
>       Start 32: kiowidgets-pastetest
> 32/47 Test #32: kiowidgets-pastetest .............................   Passed    0.69 sec
>       Start 33: kiowidgets-accessmanagertest
> 33/47 Test #33: kiowidgets-accessmanagertest .....................   Passed    0.41 sec
>       Start 34: kiowidgets-kurifiltersearchprovideractionstest
> 34/47 Test #34: kiowidgets-kurifiltersearchprovideractionstest ...   Passed    0.35 sec
>       Start 35: kiowidgets-accessmanagertest-qnam
> 35/47 Test #35: kiowidgets-accessmanagertest-qnam ................   Passed    0.34 sec
>       Start 36: kiofilewidgets-kurlnavigatortest
> 36/47 Test #36: kiofilewidgets-kurlnavigatortest .................   Passed    0.44 sec
>       Start 37: kiofilewidgets-kurlcomboboxtest
> 37/47 Test #37: kiofilewidgets-kurlcomboboxtest ..................   Passed    0.33 sec
>       Start 38: kiofilewidgets-kdiroperatortest
> 38/47 Test #38: kiofilewidgets-kdiroperatortest ..................   Passed    1.63 sec
>       Start 39: kiofilewidgets-knewfilemenutest
> 39/47 Test #39: kiofilewidgets-knewfilemenutest ..................   Passed    0.95 sec
>       Start 40: kiofilewidgets-kfilecopytomenutest
> 40/47 Test #40: kiofilewidgets-kfilecopytomenutest ...............   Passed    0.71 sec
>       Start 41: kiofilewidgets-kfileplacesmodeltest
> 41/47 Test #41: kiofilewidgets-kfileplacesmodeltest ..............   Passed    0.47 sec
>       Start 42: kioslave-httpheadertokenizetest
> 42/47 Test #42: kioslave-httpheadertokenizetest ..................   Passed    0.25 sec
>       Start 43: kioslave-httpheaderdispositiontest
> 43/47 Test #43: kioslave-httpheaderdispositiontest ...............***Failed    0.25 sec
>       Start 44: kioslave-httpauthenticationtest
> 44/47 Test #44: kioslave-httpauthenticationtest ..................   Passed    0.25 sec
>       Start 45: kioslave-httpobjecttest
> 45/47 Test #45: kioslave-httpobjecttest ..........................   Passed    0.26 sec
>       Start 46: httpfiltertest
> 46/47 Test #46: httpfiltertest ...................................   Passed    0.01 sec
>       Start 47: kioslave-kcookiejartest
> 47/47 Test #47: kioslave-kcookiejartest ..........................   Passed    0.30 sec
> 
> 94% tests passed, 3 tests failed out of 47
> 
> Total Test time (real) =  67.92 sec
> 
> The following tests FAILED:
> 	  3 - kiocore-kacltest (Failed)
> 	  8 - kiocore-jobtest (OTHER_FAULT)
> 	 43 - kioslave-httpheaderdispositiontest (Failed)
> Errors while running CTest
> Makefile:106: recipe for target 'test' failed
> make: *** [test] Error 8
> 
> 
> Thanks,
> 
> Russell Greene
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160221/55d2f5d5/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list