Review Request 127077: kio_http: read and discard body after a 404 with errorPage=false.

[Andreas Hartmetz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127077/#review92593
-----------------------------------------------------------



Still reviewing... I think this is a regression caused by
https://git.reviewboard.kde.org/r/102801/
Previously, closing the connection on any error was a crude but effective way to reduce the number of possible states. This might not be the only bug created (or exposed if you like) by that change.
Also, m_iError is a bad name for the variable, it could also mean HTTP error but in fact it's the KIO error code.

- Andreas Hartmetz


On Feb. 20, 2016, 5:50 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127077/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2016, 5:50 p.m.)
> 
> 
> Review request for KDE Frameworks, Dawit Alemayehu, Andreas Hartmetz, and Rolf Eike Beer.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> kio_http: read and discard body after a 404 with errorPage=false.
> 
> When getting a 404 error with some content, the job succeeds and returns content
> (good for webbrowsers).
> The metadata "errorPage" can be set to false so that the job fails instead
> (useful for other cases, like favicon download, file copy etc.)
> However the rest of the headers, as well as the body must still be read and
> discarded, otherwise they clobber the next request (kio_http then starts
> parsing in the middle of some headers and says "DO NOT WANT").
> 
> This is not a porting bug, I could reproduce it with kdelibs4 too.
> 
> 
> Diffs
> -----
> 
>   autotests/http_jobtest.cpp PRE-CREATION 
>   src/ioslaves/http/http.cpp e1013c8705e6588729d61ed45c43dc564415c41e 
> 
> Diff: https://git.reviewboard.kde.org/r/127077/diff/
> 
> 
> Testing
> -------
> 
> Unittest.
> 
> Please review this patch carefully, I don't have much experience with this code in kio_http, and the potential for regressions in cases that I didn't test is likely high.
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160220/62b3299a/attachment-0001.html>