Review Request 127121: KWallet::openWallet(Synchronous) : time out after 1 hour rather than 25 seconds.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127121/
-----------------------------------------------------------

(Updated Feb. 20, 2016, 8:48 p.m.)


Review request for KDE Frameworks and Valentin Rusu.


Changes
-------

Make it 2<<30 ms, i.e. 12 days if I counted correctly. I don't dare making it bigger, but it should be plenty ;)


Repository: kwallet


Description
-------

The default DBus timeout is 25 seconds, which means that if the user went to
get a cup of tea during session startup, when they come back they get prompted
with all sorts of additional non-kwallet password requests due to all kwallet
requests having timed out.

I added setTimeout in QDBusAbstractInterface in Qt 4.8 for things like this.

Testcase:
 eval `dbus-launch`
 export SSH_ASKPASS=$KDEDIR/bin/ksshaskpass
 ssh-add < /dev/null
(but the same happens with the IMAP resource etc.)


Diffs (updated)
-----

  src/api/KWallet/kwallet.cpp b72edad19840943f70755c8668668a1881f1fb39 

Diff: https://git.reviewboard.kde.org/r/127121/diff/


Testing
-------

(see commit log)


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160220/a59fa346/attachment.html>