Review Request 127031: Add function to get runtime frameworks version information

Kevin Funk kfunk at kde.org
Fri Feb 19 14:00:42 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127031/#review92564
-----------------------------------------------------------




src/lib/kcoreaddons.h (line 38)
<https://git.reviewboard.kde.org/r/127031/#comment63107>

    Maybe also add a hint / some code which shows how to use that uint? I.e. point to Qt's QT_VERSION_CHECK documentation or copy/paste it.


- Kevin Funk


On Feb. 19, 2016, 12:46 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127031/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2016, 12:46 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Adds a method similar to qVersion() that returns a string of the
> frameworks version being run. This differs from the header file which
> can only provide the version this app is compiled against.
> 
> The intended usage is in drkonqi system information.
> 
> 
> Diffs
> -----
> 
>   src/lib/CMakeLists.txt a36eed26a281baf9ef1064dfb9aed3c394c52604 
>   src/lib/kcoreaddons.h PRE-CREATION 
>   src/lib/kcoreaddons.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127031/diff/
> 
> 
> Testing
> -------
> 
> See https://git.reviewboard.kde.org/r/127032/
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160219/bf732123/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list