Review Request 127110: Drop KF5DocTools dependency

Luigi Toscano luigi.toscano at tiscali.it
Thu Feb 18 18:52:51 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127110/#review92535
-----------------------------------------------------------



Are you sure this is enough? I think you may want to conditionally disable also the final part of src/CMakeLists.txt, which installs the compatibility DTD (from "########## DocBookXML 4.2 compatibility").

- Luigi Toscano


On Feb. 18, 2016, 7:45 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127110/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2016, 7:45 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> -------
> 
> Like in many other frameworks.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 15ecead 
> 
> Diff: https://git.reviewboard.kde.org/r/127110/diff/
> 
> 
> Testing
> -------
> 
> Builds with and without KDocTools.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160218/77f09aed/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list