Review Request 127091: Fix IconItem regression in 5.19

Daniel Vrátil dvratil at kde.org
Tue Feb 16 20:16:07 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127091/
-----------------------------------------------------------

(Updated Feb. 16, 2016, 3:16 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, Plasma and David Edmundson.


Changes
-------

Submitted with commit 525bf2d377c21b41971a72d694a507bf2af0ada6 by Dan Vrátil to branch master.


Bugs: 359388
    http://bugs.kde.org/show_bug.cgi?id=359388


Repository: plasma-framework


Description
-------

Fix sni-qt icons (or generally any non-theme icons) not showing in systray after 5184ac94. The fallback code was assuming that the name always comes from QIcon::iconTheme icon.


Diffs
-----

  src/declarativeimports/core/iconitem.cpp 1d7921a 

Diff: https://git.reviewboard.kde.org/r/127091/diff/


Testing
-------

I can see sni-qt apps icons in Plasma systray again.


Thanks,

Daniel Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160216/85ee9ea2/attachment.html>


More information about the Kde-frameworks-devel mailing list