Review Request 127091: Fix IconItem regression in 5.19

[David Rosca]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127091/#review92461
-----------------------------------------------------------




src/declarativeimports/core/iconitem.cpp (line 151)
<https://git.reviewboard.kde.org/r/127091/#comment63045>

    I was just about to send the same fix!
    
    You can also check here for source.canConver<QIcon>(), but that's just a cosmetic change.
    
    Otherwise, +1 from me.


- David Rosca


On Feb. 16, 2016, 4:52 p.m., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127091/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2016, 4:52 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and David Edmundson.
> 
> 
> Bugs: 359388
>     http://bugs.kde.org/show_bug.cgi?id=359388
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Fix sni-qt icons (or generally any non-theme icons) not showing in systray after 5184ac94. The fallback code was assuming that the name always comes from QIcon::iconTheme icon.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/iconitem.cpp 1d7921a 
> 
> Diff: https://git.reviewboard.kde.org/r/127091/diff/
> 
> 
> Testing
> -------
> 
> I can see sni-qt apps icons in Plasma systray again.
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160216/58999e98/attachment-0001.html>