libkonq release? I'm missing the favicons interface

[Robby Stephenson]

On Sat, Feb 6, 2016 at 10:21 AM, David Faure <faure at kde.org> wrote:

> Unaware of this discussion (no time to read kde-devel), I have done exactly
> this during January. KIO (starting from 5.19) now has a KIOGui library
> with a
> FavIconRequestJob, which removes the dependency on the kded module
> provided by libkonq (I'll kill it soon, since it wasn't released).
> KIO::favIconForUrl(), which you mention in your mail, now uses the cache
> where FavIconRequestJob stores icons. Please port tellico to
> FavIconRequestJob and report any problems to me (or on the
> kde-frameworks-devel list, or in bugzilla).


FavIconRequestJob works great. I do see a behavioral regression in
KIconLoader::loadIcon(). In KDE4, the favicon icon name started with
"favicons/" and KIconLoader would use it as an overlay for a larger pixmap.
The code in KIconLoader::loadIcon() checks that the icon name starts with
"favicons/". With the current state, the icon name is an absolute path so
the overlay doesn't work.

> // Special case for absolute path icons.
> if (name.startsWith(QLatin1String("favicons/"))) {
>   favIconOverlay = true;
>   name =
QStandardPaths::writableLocation(QStandardPaths::GenericCacheLocation) +
'/' + name + ".png";
> }

Not a big deal at all and easy enough to compensate for. I'm not sure what
the appropriate fix is. Perhaps changing KIconLoader to check for an
absolute path that includes "favicons/" ?

Thanks again for FavIconRequestJob in 5.19, David.

Robby
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160215/d247852e/attachment.html>