Review Request 127060: Potentially fix 347962

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127060/#review92418
-----------------------------------------------------------


Ship it!




see comment


src/kdeclarative/qmlobject.cpp (line 115)
<https://git.reviewboard.kde.org/r/127060/#comment63030>

    You must be getting in here.
    
    someone  probably has
    setSource(findFile(pathThatDoesntExist));
    
    I'd upgrade that to a warning, 
    and you don't want your QPointer<> change.


- David Edmundson


On Feb. 13, 2016, 2:01 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127060/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2016, 2:01 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 347962
>     https://bugs.kde.org/show_bug.cgi?id=347962
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> I couldn't reproduce, but that's what it looks like from the backtraces.
> 
> 
> Diffs
> -----
> 
>   src/kdeclarative/qmlobject.cpp f3cee66 
> 
> Diff: https://git.reviewboard.kde.org/r/127060/diff/
> 
> 
> Testing
> -------
> 
> Tests still pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160215/b7c075b8/attachment.html>