Review Request 126876: Fix QFileDialog::openUrl() for remote files

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126876/#review92390
-----------------------------------------------------------


Ship it!




Yes in my opinion this is fine and in line with how KFileWidget already works.

I just realized that if we want to minimize the number of stat jobs, then maybe my suggestion to put this here was wrong, it will be easier to optimize it if we all do it together in KFileWidget rather than a bit here and a bit there. I wanted this "adaptation to the Qt API" not to clutter the KFileWidget API itself, but this could be done with a new KFileWidget::setFileOrDirectoryUrl() method (or something like that) that frameworkintegration calls. Anyway, can be done later if someone wants to tackle reducing the number of (blocking) stat jobs.

If setDirectory is called multiple times and if that can't be avoided, we might want to add a if (directory == m_directory) return; early return (with a new member var m_directory).

Anyhow, let's get this in, it already missed 5.19, further improvements can be done on top.

- David Faure


On Feb. 14, 2016, 6:25 a.m., Kåre Särs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126876/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2016, 6:25 a.m.)
> 
> 
> Review request for KDE Frameworks, Alex Richardson and David Faure.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> Qt does not know if the remote URL points to a file or directory. that is why options()->initialDirectory() returns the full URL even if it is a file.
> 
> 
> This fix is a bit like Alex Richardson workaround in KIO (https://git.reviewboard.kde.org/r/126831/), but in frameworkintegration in stead (I did not see his/Your KIO fix before now...)
> 
> I check the remote url in setDirectory() because setDirectoy() is called from two places.
> 
> 
> Diffs
> -----
> 
>   src/platformtheme/kdeplatformfiledialoghelper.cpp 11e7efb 
> 
> Diff: https://git.reviewboard.kde.org/r/126876/diff/
> 
> 
> Testing
> -------
> 
> Kate now happily opens local and remote folders :)
> 
> 
> File Attachments
> ----------------
> 
> firefox.desktop
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/25/60c21962-396e-468e-add9-e7112c49d7ba__firefox.desktop
> 
> 
> Thanks,
> 
> Kåre Särs
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160215/f9070cd0/attachment.html>