Review Request 127004: WIP: OpenFileManagerWindowJob

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127004/#review92385
-----------------------------------------------------------




src/widgets/openfilemanagerwindowjob.cpp (line 107)
<https://git.reviewboard.kde.org/r/127004/#comment63005>

    const QStringList urlsList = QUrl::toStringList(d->highlightUrls);



src/widgets/openfilemanagerwindowjob.cpp (line 117)
<https://git.reviewboard.kde.org/r/127004/#comment63004>

    Looking at kstartupinfo.cpp, they are UTF-8. Although that code is probably broken in case gethostname returns something non latin1. I'll add a fromUtf8 there.


- David Faure


On Feb. 7, 2016, 6:20 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127004/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2016, 6:20 p.m.)
> 
> 
> Review request for KDE Frameworks, Emmanuel Pescosta and Martin Gräßlin.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> This job uses the org.freedesktop.FileManager1 interface to highlight files within a certain folder, useful for eg. downloaded files or a "open containing folder" functionality.
> 
> 
> Diffs
> -----
> 
>   src/widgets/CMakeLists.txt 87dac50 
>   src/widgets/openfilemanagerwindowjob.h PRE-CREATION 
>   src/widgets/openfilemanagerwindowjob.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127004/diff/
> 
> 
> Testing
> -------
> 
> With Dolphin's org.freedesktop.FileManager1 service installed, I got a file highlighted properly. Without it Dolphin opened the folder without highlighting (KRun fallback).
> 
> Not sure what to do with the startup id stuff
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160215/4773edf1/attachment-0001.html>