Review Request 127024: Don't filter names if we have mimetypes
David Faure
faure at kde.org
Mon Feb 15 08:10:31 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127024/#review92384
-----------------------------------------------------------
Ship it!
Ship It!
- David Faure
On Feb. 14, 2016, 11:31 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127024/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2016, 11:31 p.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: frameworkintegration
>
>
> Description
> -------
>
> setMimeTypeFilters will call setNameFilter anyway, so we're not missing any entries, on the other hand setMimeFilter will do some nice things using the extra knowledge.
>
>
> Diffs
> -----
>
> src/platformtheme/kdeplatformfiledialoghelper.cpp 11e7efb
>
> Diff: https://git.reviewboard.kde.org/r/127024/diff/
>
>
> Testing
> -------
>
> Tested it while porting okular.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160215/78f24886/attachment.html>
More information about the Kde-frameworks-devel
mailing list