Review Request 126876: Fix QFileDialog::openUrl() for remote files

[Kåre Särs]

> On Feb. 14, 2016, 11:11 p.m., Aleix Pol Gonzalez wrote:
> > src/platformtheme/kdeplatformfiledialoghelper.cpp, line 192
> > <https://git.reviewboard.kde.org/r/126876/diff/2/?file=444275#file444275line192>
> >
> >     Wouldn't it be a good practice to assume people are doing the right thing and not passing something that isn't a folder?
> >     
> >     Do other implementations make this check? I doubt it.

>From the QFileDialog manual:
getOpenFileUrls(): "The function is used similarly to QFileDialog::getOpenFileNames(). In particular parent, caption, dir, filter, selectedFilter and options are used in the exact same way."

And in getOpenFileNames(): "The file dialog's working directory will be set to dir. If dir includes a file name, the file will be selected."

Unfortunately this does not work for remote URLs as Qt can't know if it points to a file or directory. That is why we need to check it here.


- Kåre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126876/#review92368
-----------------------------------------------------------


On Feb. 14, 2016, 6:25 a.m., Kåre Särs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126876/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2016, 6:25 a.m.)
> 
> 
> Review request for KDE Frameworks, Alex Richardson and David Faure.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> Qt does not know if the remote URL points to a file or directory. that is why options()->initialDirectory() returns the full URL even if it is a file.
> 
> 
> This fix is a bit like Alex Richardson workaround in KIO (https://git.reviewboard.kde.org/r/126831/), but in frameworkintegration in stead (I did not see his/Your KIO fix before now...)
> 
> I check the remote url in setDirectory() because setDirectoy() is called from two places.
> 
> 
> Diffs
> -----
> 
>   src/platformtheme/kdeplatformfiledialoghelper.cpp 11e7efb 
> 
> Diff: https://git.reviewboard.kde.org/r/126876/diff/
> 
> 
> Testing
> -------
> 
> Kate now happily opens local and remote folders :)
> 
> 
> File Attachments
> ----------------
> 
> firefox.desktop
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/25/60c21962-396e-468e-add9-e7112c49d7ba__firefox.desktop
> 
> 
> Thanks,
> 
> Kåre Särs
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160215/d3cdb7fb/attachment.html>