Review Request 127076: kio_http: fix mimetype determination when URL ends with '/'.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127076/
-----------------------------------------------------------

(Updated Feb. 14, 2016, 10:24 p.m.)


Review request for KDE Frameworks, Dawit Alemayehu and Andreas Hartmetz.


Changes
-------

moved some code to the .cpp file as suggested by Milian + added const


Repository: kio


Description
-------

When no Content-Type is sent by the server, we determine mimetype from
the URL and the contents. In the switch from KMimeType (which
took the fileName of the URL) and QMimeDatabase (which takes the full path),
we hit a difference: if the path ends with '/' then QMimeDatabase
assumes it's a directory, which isn't the case over HTTP.
So remove the trailing slash.

This commit introduces a test harness for kio_http: a basic HTTP server
running in a separate thread, which I wrote for KDSoap (LGPL).


Diffs (updated)
-----

  autotests/CMakeLists.txt 107263820136c599df84c7beb06a29a1c52898ae 
  autotests/http_jobtest.cpp PRE-CREATION 
  autotests/httpserver_p.h PRE-CREATION 
  autotests/httpserver_p.cpp PRE-CREATION 
  src/ioslaves/http/http.cpp e1013c8705e6588729d61ed45c43dc564415c41e 

Diff: https://git.reviewboard.kde.org/r/127076/diff/


Testing
-------

Unit test + watching kio_http debug output in my current work on keditbookmarks favicon support.

The missing Content-Type is due to another bug, but that's for the next RR.


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160214/5ba30a60/attachment.html>