Review Request 126876: Fix QFileDialog::openUrl() for remote files

[Kåre Särs]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126876/
-----------------------------------------------------------

(Updated Feb. 14, 2016, 6:25 a.m.)


Review request for KDE Frameworks, Alex Richardson and David Faure.


Changes
-------

Updated the comment and removd the unnecessary KFileItem


Repository: frameworkintegration


Description (updated)
-------

Qt does not know if the remote URL points to a file or directory. that is why options()->initialDirectory() returns the full URL even if it is a file.


This fix is a bit like Alex Richardson workaround in KIO (https://git.reviewboard.kde.org/r/126831/), but in frameworkintegration in stead (I did not see his/Your KIO fix before now...)

I check the remote url in setDirectory() because setDirectoy() is called from two places.


Diffs (updated)
-----

  src/platformtheme/kdeplatformfiledialoghelper.cpp 11e7efb 

Diff: https://git.reviewboard.kde.org/r/126876/diff/


Testing
-------

Kate now happily opens local and remote folders :)


File Attachments (updated)
----------------

firefox.desktop
  https://git.reviewboard.kde.org/media/uploaded/files/2016/01/25/60c21962-396e-468e-add9-e7112c49d7ba__firefox.desktop


Thanks,

Kåre Särs

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160214/92b57527/attachment.html>