Review Request 127029: Fix chromium/wine apps not being added to the menu for some distributions.

David Faure faure at kde.org
Sat Feb 13 10:34:19 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127029/#review92309
-----------------------------------------------------------


Ship it!




Ship It!

- David Faure


On Feb. 10, 2016, 2:07 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127029/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2016, 2:07 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> xdg-menu install installs local .menu files into .config/menus
> /applications-merged/
> 
> kservice merges local menus from
> .config/menus/$APPLICATIONS_MENU_NAME-merged where applications_menu_name
> is a cmake variable of where to install the base menu.
> 
> In most cases it works as $APPLICATIONS_MENU_NAME is "applications"
> by default. However some special distributions rename it.
> 
> The specification does say you should derive this folder from the menu
> you're loading, so we're half following it.
> However, there's an overriding clause that if you're loading an
> application menu (i.e kde-applications.menu) the default merge directory
> must be "applications-merged" instead.[1]
> 
> BUG: 213972
> 
> [1]https://specifications.freedesktop.org/menu-spec/menu-spec-
> latest.html
> 
> 
> Diffs
> -----
> 
>   src/sycoca/vfolder_menu.cpp d3e31c3a8c98506b8cd6c4964f61d0245d22d152 
> 
> Diff: https://git.reviewboard.kde.org/r/127029/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160213/2721da7b/attachment.html>


More information about the Kde-frameworks-devel mailing list