Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

[Kåre Särs]

> On Feb. 12, 2016, 3:55 p.m., Aleix Pol Gonzalez wrote:
> > src/kcatalog.cpp, line 179
> > <https://git.reviewboard.kde.org/r/127048/diff/2/?file=444140#file444140line179>
> >
> >     elseif?
> 
> Andreas Cord-Landwehr wrote:
>     Sure? I must admit, my Windows compiler foo is not very elaborated.
>     Actually, I thought _MSC_VER is a MSVC specific compiler setting and Q_OS_WIN is more a platform specific define. If the meaning is the same, I'll gladly change this.

I tink the original idea has been that on windows visibility (dll export/import) is used and on non windows it is not used by default. I wonder if this has compiled at all with mingw and gnu-gettext (double definition)... 

So far non windows has always not used visibility here -> it should not break anything non windows with #ifdef Q_OS_WIN ... #else ... #endif


- Kåre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127048/#review92301
-----------------------------------------------------------


On Feb. 12, 2016, 3:47 p.m., Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127048/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2016, 3:47 p.m.)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez and Chusslove Illich.
> 
> 
> Repository: ki18n
> 
> 
> Description
> -------
> 
> On Android, we do not have libintl but only libintl-lite, which does
> not provide _nl_msg_cat_cntr. Actually, _nl_msg_cat_cntr is a GNU
> gettext specific tool to prevent wrong localization after runtime language
> changes. Thus, it is tied to the specific GNU gettext implementation.
> 
> 
> Diffs
> -----
> 
>   src/kcatalog.cpp 095a6be 
> 
> Diff: https://git.reviewboard.kde.org/r/127048/diff/
> 
> 
> Testing
> -------
> 
> Tested compilation on Android and Linux.
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160212/8e20cfe0/attachment.html>