Review Request 127046: Move popup menu image actions into a submenu

Thomas Pfeiffer colomar at autistici.org
Fri Feb 12 14:37:48 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127046/#review92299
-----------------------------------------------------------



I wouldn't say that all actions for images are rarely used.
I don't see why viewing, copying or saving an image is less frequently done than the same things regarding the link. Can't we have those three still on the first level and then a "More..." option with further actions?

- Thomas Pfeiffer


On Feb. 11, 2016, 6:18 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127046/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2016, 6:18 p.m.)
> 
> 
> Review request for KDE Frameworks and KDE Usability.
> 
> 
> Repository: khtml
> 
> 
> Description
> -------
> 
> The popup menu over an image (with actions "Save Image As..." etcetera, see screen shot) has in total 6 image actions which are not frequently used but make the menu very long.  Moving these actions onto a submenu makes the top level menu smaller and more logically grouped.
> 
> 
> Diffs
> -----
> 
>   src/khtml_ext.cpp 0f522f4 
> 
> Diff: https://git.reviewboard.kde.org/r/127046/diff/
> 
> 
> Testing
> -------
> 
> Built KHTML with these changes, tested in Konqueror.
> 
> 
> File Attachments
> ----------------
> 
> Popup menu before
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/02/11/55c12311-73a3-472a-8a9a-6b6b9fce9de7__before.png
> Popup menu after
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/02/11/313dbe3b-efb4-475c-bf76-8516f5bc85b4__after.png
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160212/3225dd44/attachment.html>


More information about the Kde-frameworks-devel mailing list