Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

Aleix Pol Gonzalez aleixpol at kde.org
Fri Feb 12 00:02:36 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127048/#review92280
-----------------------------------------------------------




src/kcatalog.cpp (line 179)
<https://git.reviewboard.kde.org/r/127048/#comment62945>

    maybe it should be `#ifdef libintl-lite` no?


- Aleix Pol Gonzalez


On Feb. 11, 2016, 8:11 p.m., Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127048/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2016, 8:11 p.m.)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez and Chusslove Illich.
> 
> 
> Repository: ki18n
> 
> 
> Description
> -------
> 
> On Android, we do not have libintl but only libintl-lite, which does
> not provide _nl_msg_cat_cntr. Actually, _nl_msg_cat_cntr is a GNU
> gettext specific tool to prevent wrong localization after runtime language
> changes. Thus, it is tied to the specific GNU gettext implementation.
> 
> 
> Diffs
> -----
> 
>   src/kcatalog.cpp 095a6beec721729537a89214a1fbdb661fbfb548 
> 
> Diff: https://git.reviewboard.kde.org/r/127048/diff/
> 
> 
> Testing
> -------
> 
> Tested compilation on Android and Linux.
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160212/e9ac16f2/attachment.html>


More information about the Kde-frameworks-devel mailing list