Review Request 127024: Don't filter names if we have mimetypes

Aleix Pol Gonzalez aleixpol at kde.org
Wed Feb 10 02:20:40 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127024/
-----------------------------------------------------------

(Updated Feb. 10, 2016, 3:20 a.m.)


Review request for KDE Frameworks.


Changes
-------

If directories are an accepted mimetype, include the Directory mode.


Repository: frameworkintegration


Description
-------

setMimeTypeFilters will call setNameFilter anyway, so we're not missing any entries, on the other hand setMimeFilter will do some nice things using the extra knowledge.


Diffs (updated)
-----

  src/platformtheme/kdeplatformfiledialoghelper.cpp 11e7efb 

Diff: https://git.reviewboard.kde.org/r/127024/diff/


Testing
-------

Tested it while porting okular.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160210/c1c6eb17/attachment.html>


More information about the Kde-frameworks-devel mailing list