Review Request 127002: Add KLocalizedString::getLanguages()

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127002/#review92122
-----------------------------------------------------------



Qt API guidelines say to use getFoo() only when using "out parameters", e.g. QRect::getCoords or QRect::getRect, or static methods that are going to ask the user (QFileDialog::getOpenFileName etc.). 

Static getters are not called getFoo(), so I recommend languages() here.

- David Faure


On Feb. 7, 2016, 8:28 a.m., Pino Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127002/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2016, 8:28 a.m.)
> 
> 
> Review request for KDE Frameworks and Chusslove Illich.
> 
> 
> Repository: ki18n
> 
> 
> Description
> -------
> 
> Easy way to get the ordered list of languages where translations are looked into.
> 
> This makes it possible to lookup other kind of translated resources using the same list of priorities of languages.
> 
> (Note: I'm not sure about which name fits better, i.e. `languages()` or `getLanguages()`; I chose the latter as the former could be mistaken as non-static method of `KLocalizedString`.)
> 
> 
> Diffs
> -----
> 
>   src/klocalizedstring.h 87030a443d36c3e9ca57e1e61ba1cba13f39bbee 
>   src/klocalizedstring.cpp 20b2bd46d6748b540e4a0bc9b3c3168e55cf47f3 
> 
> Diff: https://git.reviewboard.kde.org/r/127002/diff/
> 
> 
> Testing
> -------
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160207/39fd0b04/attachment.html>