Review Request 126999: Fix crash in KJob dialogs.

Wolfgang Bauer wbauer at tmo.at
Sat Feb 6 20:13:45 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126999/#review92118
-----------------------------------------------------------



I tried the patch and it fixes the crash from the bug report for me.
Before I was able to reproduce it reliably.

- Wolfgang Bauer


On Feb. 6, 2016, 8:42 nachm., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126999/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2016, 8:42 nachm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 356321
>     https://bugs.kde.org/show_bug.cgi?id=356321
> 
> 
> Repository: kjobwidgets
> 
> 
> Description
> -------
> 
> Guard "this" being deleted whilst running new eventloop
> 
> KMessageBox spawns a new event loop, during which the parent kjob can be
> completed and deleted, deleting the UIDelegate with it.
> 
> BUG: 356321
> 
> 
> Diffs
> -----
> 
>   src/kdialogjobuidelegate.cpp 5ede372c3f5fb0c39d8c25941570b741f8316ba6 
> 
> Diff: https://git.reviewboard.kde.org/r/126999/diff/
> 
> 
> Testing
> -------
> 
> None.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160206/f5408fb8/attachment.html>


More information about the Kde-frameworks-devel mailing list