Review Request 126955: Fix crash in activities context menu

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126955/
-----------------------------------------------------------

(Updated Feb. 6, 2016, 10:03 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit b3c8ad1ad48d65ea77724f94073909dc8ab97596 by David Edmundson to branch master.


Bugs: 351485
    http://bugs.kde.org/show_bug.cgi?id=351485


Repository: kactivities


Description
-------

Currently we call deleteLater() from inside ::run which is running in a
different thread than the receiving object.
(QThread objects live in the thread that created them, not in the thread they create) 

This patch causes deleteLater to be run in the right thread.

QCoreApplication::postEvent is thread safe but it needs to be in the right thread to work out the correct event loop level for deferred delete events.

BUG: 351485


Diffs
-----

  src/workspace/fileitemplugin/FileItemLinkingPlugin.cpp a88713204c95d7c4a7502a1b31ca51962186a555 
  src/workspace/fileitemplugin/FileItemLinkingPluginActionLoader.h 50dccc5c80b24af9d38ddb021d4c69a2348630a5 
  src/workspace/fileitemplugin/FileItemLinkingPluginActionLoader.cpp 3343eb4c5cfe209e20b0210a2b7fdf980a1e8b4a 

Diff: https://git.reviewboard.kde.org/r/126955/diff/


Testing
-------

Right click in dolpin. Still works.

Couldn't reproduce the original crash, so I don't know for sure it fixes it. 
Debug in qcoreapplication showed we got a different eventLoopLevel on the QDeferredDeleteEvent


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160206/8634dbca/attachment-0001.html>