Review Request 126948: Simplify attica plugin look-up and initialization

Aleix Pol Gonzalez aleixpol at kde.org
Tue Feb 2 02:06:53 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126948/
-----------------------------------------------------------

(Updated Feb. 2, 2016, 2:06 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit 58e6ed4f6a6c24737cc3ca1e5082c3fe976eda46 by Aleix Pol to branch master.


Repository: attica


Description
-------

Just use QPluginLoader instead of doing it locally (and with an awkward blocking QProcess call)


Diffs
-----

  src/providermanager.cpp 0536a1f 

Diff: https://git.reviewboard.kde.org/r/126948/diff/


Testing
-------

Test still passes, initializing attica still finds the right plugin on my system.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160202/68f2b2ed/attachment.html>


More information about the Kde-frameworks-devel mailing list