Review Request 126955: Fix crash in activities context menu

David Edmundson david at davidedmundson.co.uk
Mon Feb 1 21:16:18 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126955/
-----------------------------------------------------------

Review request for KDE Frameworks.


Bugs: 351485
    http://bugs.kde.org/show_bug.cgi?id=351485


Repository: kactivities


Description
-------

Currently we call deleteLater() from inside ::run which is running in a
different thread than the receiving object.
(QThread objects live in the thread that created them, not in the thread they create) 

This patch causes deleteLater to be run in the right thread.

QCoreApplication::postEvent is thread safe but it needs to be in the right thread to work out the correct event loop level for deferred delete events.

BUG: 351485


Diffs
-----

  src/workspace/fileitemplugin/FileItemLinkingPluginActionLoader.cpp 3343eb4c5cfe209e20b0210a2b7fdf980a1e8b4a 

Diff: https://git.reviewboard.kde.org/r/126955/diff/


Testing
-------

Right click in dolpin. Still works.

Couldn't reproduce the original crash, so I don't know for sure it fixes it. 
Debug in qcoreapplication showed we got a different eventLoopLevel on the QDeferredDeleteEvent


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160201/a419b818/attachment.html>


More information about the Kde-frameworks-devel mailing list