Review Request 126948: Simplify attica plugin look-up and initialization
Aleix Pol Gonzalez
aleixpol at kde.org
Mon Feb 1 19:37:57 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126948/
-----------------------------------------------------------
(Updated Feb. 1, 2016, 8:37 p.m.)
Review request for KDE Frameworks.
Changes
-------
--debug
Repository: attica
Description
-------
Just use QPluginLoader instead of doing it locally (and with an awkward blocking QProcess call)
Diffs (updated)
-----
src/providermanager.cpp 0536a1f
Diff: https://git.reviewboard.kde.org/r/126948/diff/
Testing
-------
Test still passes, initializing attica still finds the right plugin on my system.
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160201/4aea7d72/attachment.html>
More information about the Kde-frameworks-devel
mailing list