Review Request 126893: [kioslave/remote] fix knetattach .desktop filename

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126893/#review91841
-----------------------------------------------------------


Ship it!




Ship It!

- David Faure


On Jan. 29, 2016, 11:29 a.m., Takahiro Hashimoto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126893/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2016, 11:29 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 358723
>     https://bugs.kde.org/show_bug.cgi?id=358723
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> The knetattach .desktop file has been renamed to 'org.kde.knetattach.desktop'.
> The wizard service name should be changed to the same string.
> 
> This patch simply fixes service name of knetatach.
> 
> 
> Diffs
> -----
> 
>   kioslave/remote/remoteimpl.cpp ad04a7b 
> 
> Diff: https://git.reviewboard.kde.org/r/126893/diff/
> 
> 
> Testing
> -------
> 
> Confirmed the "Add Network Folder" icon rework in dolphin.
> kioslave/remote/tests/testremote has been passed.
> 
> We may have some issues about knetattach. At present I cannot create sftp network folder. I have confirmed that the ftp network folder works correctly.
> 
> 
> Thanks,
> 
> Takahiro Hashimoto
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160201/18859c87/attachment-0001.html>