Review Request 129638: KIO: improve and export KPasswdServerClient class, the client API for kpasswdserver.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129638/
-----------------------------------------------------------

(Updated Dec. 31, 2016, 9:30 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit e01af01e7c2f8ee47d607ffadd36e59f6563ce4d by David Faure to branch master.


Repository: kio


Description
-------

I need it in webenginepart to handle authenticationRequired(),
since webengine doesn't use kioslaves.
    
This commit includes:
- moving the handling of sequence numbers into the class, for convenience and encapsulation
- finishing to document all parameters to the methods
- moving KPasswdServerClient outside of the KIO namespace (since it already has a K prefix, both would look weird)


Diffs
-----

  src/core/CMakeLists.txt d298e54c36ca359ec78b8a1bd8cebb48312b49a9 
  src/core/kpasswdserverclient.cpp ad7ed32925df22079029ea2b94fb2d191e62a35a 
  src/core/kpasswdserverclient_p.h 37c924a653b87f52e3f6e9059b4846703f5c000c 
  src/core/kpasswdserverloop.cpp d7ceab71ff30d9059e7272511fee94a88da877e9 
  src/core/kpasswdserverloop_p.h 00bf7c61679e75cd28a5dffb7297cf4d72077017 
  src/core/slavebase.cpp 44ecae555bb5bf787a18e295941c6bace549db26 

Diff: https://git.reviewboard.kde.org/r/129638/diff/


Testing
-------

kpasswdserver is unittested, this is just the client-side API (wrapping dbus calls).

The webenginepart implementation using this class works (for the one host I tested, which requires HTTP auth)


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161231/2f17ece9/attachment-0001.html>