Review Request 129734: KSycoca unittest: reduce the amount of waiting, if Qt >= 5.8 is used.

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129734/#review101689
-----------------------------------------------------------


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Dec. 31, 2016, 2:16 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129734/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2016, 2:16 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Patrick Spendrin, and Hannah von Reth.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> lastModified() finally returns milliseconds (qtbase commit 494ced1), which
> means we don't need to wait a whole second just to detect that a file was
> modified.
> 
> Not sure about Windows though...
> 
> 
> Diffs
> -----
> 
>   autotests/ksycocatest.cpp 4564ee6750a80a109492c197c83944e129dcabac 
> 
> Diff: https://git.reviewboard.kde.org/r/129734/diff/
> 
> 
> Testing
> -------
> 
> ksycocatest runs much faster now (700 ms instead of 7 s), and still passes
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161231/97cffcf0/attachment.html>