Review Request 129733: KSycoca: don't follow symlink to directories, it creates a risk of recursion

David Faure faure at kde.org
Sat Dec 31 13:06:05 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129733/
-----------------------------------------------------------

Review request for KDE Frameworks, Albert Astals Cid and René J.V. Bertin.


Repository: kservice


Description
-------

Symlinks to (desktop) files are still supported.


Diffs
-----

  autotests/ksycocatest.cpp 4564ee6750a80a109492c197c83944e129dcabac 
  src/sycoca/ksycocautils_p.h f144a80ea6d845ed5eaff41689756b30f17d9391 

Diff: https://git.reviewboard.kde.org/r/129733/diff/


Testing
-------

Added unittest (which failed before the fix, passes after the fix)


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161231/2b39e4aa/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list