Review Request 129648: New widget: tooltip that contains another widget

[Elvis Angelaccio]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129648/
-----------------------------------------------------------

(Updated Dec. 29, 2016, 10:11 a.m.)


Review request for KDE Frameworks, Ben Cooksley, Christoph Feck, and Martin Gräßlin.


Changes
-------

* QScopedPointer for the d pointer
* QDesktopWidget -> QScreen (loop over available geometries and check which one contains the mouse cursor)


Repository: kwidgetsaddons


Description
-------

This new widget is based on the KToolTip code that is duplicated across multiple products: at least Dolphin, systemsettings, kinfocenter, ktp-contact-list.

Rationale: with a single class in frameworks, it will be possible to apply features/fixes only once. See for example the comments in https://phabricator.kde.org/D3112

A new feature that the old code doesn't have is the delayed hide: this makes it possible to actually use the widget shown in the tooltip.


Diffs (updated)
-----

  autotests/CMakeLists.txt ffcce3a046ec98b07c4677578f6bc997de1ef16b 
  autotests/ktooltipwidgettest.h PRE-CREATION 
  autotests/ktooltipwidgettest.cpp PRE-CREATION 
  src/CMakeLists.txt de0a8d965f1541d5ffeec93d1aa06600b0b9c138 
  src/ktooltipwidget.h PRE-CREATION 
  src/ktooltipwidget.cpp PRE-CREATION 
  tests/CMakeLists.txt fcb348b1ae9d4270468c3f9003c5ba5f3903db84 
  tests/ktooltipwidget_test.h PRE-CREATION 
  tests/ktooltipwidget_test.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/129648/diff/


Testing
-------

Manual test works both in X11 and Wayland. Unit tests pass.

Ported Dolphin locally to this new class, everything seems to work (and this will fix bug [#352276](https://bugs.kde.org/show_bug.cgi?id=352276) and [#371223](https://bugs.kde.org/show_bug.cgi?id=371223)).


Thanks,

Elvis Angelaccio

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161229/70bab770/attachment.html>