Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129299/#review101640
-----------------------------------------------------------


Fix it, then Ship it!




Looks good (will need a call from KParts to the new protected method of course).


src/kxmlguiwindow.h (line 334)
<https://git.reviewboard.kde.org/r/129299/#comment68068>

    trailing whitespace



src/kxmlguiwindow.h (line 339)
<https://git.reviewboard.kde.org/r/129299/#comment68069>

    @since 5.30



src/kxmlguiwindow.cpp (line 407)
<https://git.reviewboard.kde.org/r/129299/#comment68070>

    trailing whitespace



src/kxmlguiwindow.cpp (line 426)
<https://git.reviewboard.kde.org/r/129299/#comment68071>

    Use qCDebug or remove


- David Faure


On Dec. 28, 2016, 10:42 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129299/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2016, 10:42 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Elvis Angelaccio.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> -------
> 
> Add a warning at the createGui stage about ambiguous shortcuts being found in the same action collection.
> 
> This is usually a developer issue, but the error message about ambiguity will only show up when someone tries to use the shortcut, so it is relatively easy to miss if you do not try all your actions via a shortcut.
> 
> Also if the involved shortcut is one of the non primary shortcuts of edit_cut + deletefile, just give it away, since it's Shift+Delete being fought over as part of our defaults being ambiguous.
> 
> 
> Diffs
> -----
> 
>   src/kxmlguiwindow.h 3c61939 
>   src/kxmlguiwindow.cpp 519fb26 
> 
> Diff: https://git.reviewboard.kde.org/r/129299/diff/
> 
> 
> Testing
> -------
> 
> gwenview without any patch gives the warning
> gwenview with https://git.reviewboard.kde.org/r/129717/ doesn't give the warning (since it's using the standard actions instead of a own one for delete)
> gwenview with https://git.reviewboard.kde.org/r/129718/ doesn't give the warning (since it's manually removing Shift+Delete for cut)
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161229/12638b64/attachment-0001.html>